Updated OpenShift Ansible Broker documents #7057
Conversation
adellape
added
branch/enterprise-3.7
peer-review-needed
openshift-ci-robot
added
the
size/M
| ---- | ||
|
|
||
| .. Next, update `com.redhat.apb.spec` in the `LABEL` instruction with a base64 | ||
| encoded version of *_apb.yml_*. To do this, run `apb prepare`: | ||
| + |
There was a problem hiding this comment.
Do we need the The first and Next here? These are numbered steps.
| with the OpenShift Container Registry in conjunction with the OAB, a whitelist | ||
| must be defined. By default, the whitelist is empty so that a user cannot add | ||
| APB images to the broker without a cluster administrator configuring the broker. | ||
|
|
There was a problem hiding this comment.
Is this task required to use OAB? If not, should we mention this?
You can use OAB with any registry, as configured in....
There was a problem hiding this comment.
Yes a whitelist must be defined or the Broker will completely ignore APBs. End-users will simply not see any APBs and it is not apparent what is going wrong.
| ==== Configuring the OpenShift Ansible Broker for Local APB Development | ||
|
|
||
| In order to do xref:../../apb_devel/index.adoc#apb-devel-intro[APB development] | ||
| with the OpenShift Container Registry in conjunction with the OAB, a whitelist |
There was a problem hiding this comment.
Do we need to say here a whitelist of images that OAB can access... (or similar)?
|
@adellape Few questions. |
adellape
force-pushed
the
dymurray-doc
branch
from
a3be0dc to
442d9a6
Compare
|
@mburke5678 Thank you, edits made. @dymurray I've given the PV-related steps their own subheading so that it's more obvious what each procedure is for (as well as tweaked the "Configuring the OpenShift Ansible Broker" intro. WDYT? |
|
[rev_history] |
|
@vikram-redhat I noticed this was still in Staging but then I also noticed A) I forgot to squash this down to 1 commit (oops) and also B) I think I forgot to cherry-pick this to the stage branch. Is the latter what's holding it up? I'll do the needful once you confirm. |
|
@adellape - this shouldn't be in staging. I forgot to create a separate milestone last week to move staging PRs to the published milestones. Sorry! But yeah, if it didn't get cherry picked then it wouldn't have got published. So go ahead and CP to the right branches and it can get published next time. And change the milestone to next release. I will move the rest to the Published milestone today. |
adellape
removed
the
peer-review-needed
(cherry picked from commit 0c1280b) xref:openshift#7057
(cherry picked from commit 0c1280b) xref:openshift#7057
(cherry picked from commit 442d9a6) xref:openshift#7057
(cherry picked from commit 442d9a6) xref:openshift#7057
|
@vikram-redhat Thanks! Done. |
5 participants
Picks up #6780 and makes edits.
@dymurray @openshift/team-documentation PTAL
Preview:
http://file.rdu.redhat.com/~adellape/010918/dymurray-doc/apb_devel/writing/getting_started.html#apb-devel-writing-gs-creating
http://file.rdu.redhat.com/~adellape/010918/dymurray-doc/install_config/install/advanced_install.html#configuring-oab-local-apb-devel